Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eof: Detect unused inputs #1122

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

eof: Detect unused inputs #1122

wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 4, 2025

Add one more EOF validation rule: all code section inputs must be used. This is validated by tracking if any instruction in the code section reaches the stack bottom (height 0).

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 25.54%. Comparing base (dd38ff4) to head (173dab9).

Files with missing lines Patch % Lines
lib/evmone/eof.cpp 0.00% 7 Missing ⚠️
test/unittests/eof_validation.cpp 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dd38ff4) and HEAD (173dab9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (dd38ff4) HEAD (173dab9)
eof_execution_spec_tests 1 0
unittests 1 0
ethereum_tests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1122       +/-   ##
===========================================
- Coverage   94.29%   25.54%   -68.76%     
===========================================
  Files         159      159               
  Lines       17343    17352        +9     
===========================================
- Hits        16354     4432    -11922     
- Misses        989    12920    +11931     
Flag Coverage Δ
eof_execution_spec_tests ?
ethereum_tests ?
ethereum_tests_silkpre 18.96% <0.00%> (-0.01%) ⬇️
execution_spec_tests 21.79% <0.00%> (-0.02%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.hpp 3.33% <ø> (-96.67%) ⬇️
test/unittests/eof_validation_stack_test.cpp 0.00% <ø> (-100.00%) ⬇️
test/unittests/eof_validation.cpp 0.00% <0.00%> (-93.45%) ⬇️
lib/evmone/eof.cpp 0.34% <0.00%> (-85.45%) ⬇️

... and 119 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant